fix: remove v0.1 experiment flag toggle from create feature modal#7907
Open
Zaimwa9 wants to merge 1 commit into
Open
fix: remove v0.1 experiment flag toggle from create feature modal#7907Zaimwa9 wants to merge 1 commit into
Zaimwa9 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
front-end
Contributor
Docker builds report
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Contributor
Visual Regression17 screenshots compared. See report for details. |
| import ConfirmToggleFeature from 'components/modals/ConfirmToggleFeature' | ||
| import ConfirmRemoveFeature from 'components/modals/ConfirmRemoveFeature' | ||
| import CreateFlagModal from 'components/modals/create-feature' | ||
| import CreateExperimentModal from 'components/modals/create-experiment' |
Contributor
There was a problem hiding this comment.
Are we still gonna keep CreateExperimentModal ?
Just checking to prevent dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Removes the legacy "Experiment flag" toggle from the create/edit feature modal — this was a v0.1 artifact superseded by the experiment freeze mechanism which checks for running experiments via the API.
How did you test this code?