add file lock to coordinate racing cargo gpu installs#622
Open
Firestar99 wants to merge 1 commit into
Open
Conversation
Firestar99
force-pushed
the
install_file_lock
branch
from
b391ce9 to
19a5b7f
Compare
LegNeato
requested changes
Jun 29, 2026
LegNeato
left a comment
LegNeato
left a comment
Collaborator
There was a problem hiding this comment.
File locking in notorious to get right with all the edge cases...perhaps we should use https://crates.io/crates/fd-lock or https://crates.io/crates/gix-lock or https://crates.io/crates/fslock ?
Member
Author
|
My read was that many of those crates were made before file locking was added to the standard library August last year. Since them, even cargo adopted the functions from std. The bit of custom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #621