fix: strip trailing semicolon from ALTER statement options#1734
Open
CsongSY wants to merge 1 commit into
Open
Conversation
A trailing semicolon in the ALTER statement was carried into alterStatementOptions by the greedy (.*$) capture and never trimmed. When those options are spliced into a larger statement (e.g. appending ", ALGORITHM=INSTANT" in generateInstantDDLQuery) the semicolon lands mid-statement. With multiStatements=true on the applier connection this turns one INSTANT DDL into two statements, silently degrading to a native online DDL and, on error, falling back to the full copy. Trim the trailing terminator once in ParseAlterStatement so the options stay a clean fragment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trailing semicolon in the ALTER statement was carried into alterStatementOptions by the greedy (.*$) capture and never trimmed. When those options are spliced into a larger statement (e.g. appending ", ALGORITHM=INSTANT" in generateInstantDDLQuery) the semicolon lands mid-statement. With multiStatements=true on the applier connection this turns one INSTANT DDL into two statements, silently degrading to a native online DDL and, on error, falling back to the full copy.
Trim the trailing terminator once in ParseAlterStatement so the options stay a clean fragment.