fix(integration): prevent stale script help guidance#3309
Draft
darion-yaphet wants to merge 1 commit into
Draft
Conversation
The integration lifecycle commands already accept the Python script type through the shared script-type resolver. Their option help still mentioned only shell and PowerShell, which made supported usage look invalid. Constraint: Script type choices are defined centrally and currently include sh, ps, and py. Confidence: high Scope-risk: narrow Tested: .venv/bin/specify integration install --help Tested: .venv/bin/specify integration switch --help Tested: .venv/bin/specify integration upgrade --help Tested: .venv/bin/python -m pytest tests/integrations/test_integration_subcommand.py -q Assisted-by: OpenAI Codex (model: GPT-5, autonomous)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI help text for specify integration install, switch, and upgrade so the --script option accurately lists all supported script types, including Python (py), aligning the UX with the already-supported script-type resolver (SCRIPT_TYPE_CHOICES includes py).
Changes:
- Updated
--scripthelp text inintegration installto includepy. - Updated
--scripthelp text inintegration switchandintegration upgradeto includepy.
Show a summary per file
| File | Description |
|---|---|
| src/specify_cli/integrations/_install_commands.py | Expands --script option help text to include py for specify integration install. |
| src/specify_cli/integrations/_migrate_commands.py | Expands --script option help text to include py for specify integration switch and upgrade. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
Collaborator
|
Setting this to draft until all the sub issues mentioned in #3277 have been delivered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the --script help text for specify integration install, switch, and upgrade so it lists all supported script types: sh, ps, and py.
The commands already accept py through the shared script-type resolver, but the help text only mentioned shell and PowerShell. This made valid Python-script usage look unsupported.
Testing