doc: add note on visibility of CI failures to new contributor guide#64256
Open
sxa wants to merge 1 commit into
Open
doc: add note on visibility of CI failures to new contributor guide#64256sxa wants to merge 1 commit into
sxa wants to merge 1 commit into
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Collaborator
|
Review requested:
|
Member
Author
|
FYI @MikeMcC399 as someone who has experienced this recently :-) LMK what you think of the wording. I've tried to keep it short but with the info that's needed. |
MikeMcC399
reviewed
Jul 2, 2026
Comment on lines
+171
to
+176
| Since read access to the CI is also restricted, one of the collaborators also will need to let | ||
| you know about any failures unless you are a member of one of the platform teams in the Node.js | ||
| organisation. If after a day or so from a collaborator triggering a CI your PR shows a failure | ||
| in either the `node-test-pull-request` or `node-test-commit-*` checks it's worth adding a | ||
| comment to the PR asking what tests are failed, as the collaborator may not realise that you | ||
| cannot see the results directly in the CI. |
Contributor
There was a problem hiding this comment.
In this section, I'd suggest referring specifically to the Jenkins CI. There is no restriction on viewing the GitHub Actions CI.
I would also remove the reference to "unless you are a member of one of the platform teams in the Node.js
organisation" since this is a document for first-time contributors.
I did actually bring up this issue when the original PR was submitted.
See #63685 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some new contributors won't be able to access the CI and will only see github check failures when a test run in jenkins fails we should make it clear that they will need assistance from a collaborator/platform team member to know which tests caused it to fail.