build: fix Windows small-icu build with ClangCL#64263
Open
moluopro wants to merge 1 commit into
Open
Conversation
Signed-off-by: moluopro <moluopro@qq.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the static
libnodelibrary withsmall-icuon Windows, thegenccodestep fails under ClangCL because the target CPU architecture is not passed to the tool.The Windows full-ICU branch already passes
-c <(target_arch)togenccodewhenclang==1, while preserving the existing MSVC command. The small-ICU branch did not have the same conditional handling, so it hit ICU's architecture check under ClangCL.This change makes the Windows small-ICU branch consistent with the full-ICU branch:
-c <(target_arch)whenclang==1.genccodecommand unchanged for the non-ClangCL MSVC path.Reproduction
Windows builds for Node.js 24+ use ClangCL, and the build fails with: