Fix PyScript root component not hiding after render error#1347
Open
Prachi-Gupta2808 wants to merge 1 commit into
Open
Fix PyScript root component not hiding after render error#1347Prachi-Gupta2808 wants to merge 1 commit into
Prachi-Gupta2808 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where a PyScript root component becomes unresponsive after an exception is raised during rendering.
Previously, the root model was updated using
dict.update(), which could leave stale keys from the previous render. This caused the old DOM to remain visible instead of hiding the failed root component. The fix clears the existing root model before applying the latest update, ensuring the rendered state accurately reflects the current layout.I have also added a regression test to verify that when a PyScript root component raises an exception during rendering, the component is removed from the page instead of leaving stale content behind.
Closes #1276
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).