FileList#<< should skip excluded entries#750
Open
chatman-media wants to merge 1 commit into
Open
Conversation
include() has always filtered out anything matching an exclude pattern, but << just appended straight to @Items with no check. So exclude("abc.c") followed by << "abc.c" left abc.c in the list, while the equivalent include("abc.c") correctly dropped it. Added a test for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an inconsistency between
includeand<<onFileList:exclude("abc.c")followed byinclude("abc.c")correctly drops it, but the same thing with<<leavesabc.csitting in the list. Turns out<<never checked exclusion at all — it just pushed straight onto@items, unlikeadd_matchingwhich already guards withexcluded_from_list?before appending glob matches.Fixed
<<to skip the append when the item matches an exclude pattern, same checkadd_matchingalready does. Added a test that exercisesexclude+<<together (also confirmedtest_appendand friends still pass with no excludes set, so plain chaining is untouched).Also relevant to #637, which reported the same thing.