resolver: don't use Finalize when resolving visibilities during AST expansion#158689
Open
LorrensP-2158466 wants to merge 1 commit into
Open
resolver: don't use Finalize when resolving visibilities during AST expansion#158689LorrensP-2158466 wants to merge 1 commit into
Finalize when resolving visibilities during AST expansion#158689LorrensP-2158466 wants to merge 1 commit into
Conversation
Contributor
Author
|
lets see what CI says. |
Contributor
Author
|
This should probably have a crater check run, right? |
Contributor
|
Could you add the " |
Contributor
Beta run should be enough, if this didn't break anything in the test suite, then I'm 99% sure it won't break anything in practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During AST expansion we need to resolve visibilities of items. It uses
Finalizeto make sure to get a definite result on the resolution (a sort of hacky way). this pr disables the use ofFinalizeas it contradicts the invariant proposed by it: