fix(landing): inset careers row hover, drop trusted-by section, gate contact submit#5380
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The careers page no longer renders the Trusted by logo block below open roles. Each careers job link row gets inset horizontal padding ( The contact form Send message button stays disabled until name, a valid email ( Reviewed by Cursor Bugbot for commit 131bcbd. Configure here. |
Greptile SummaryThree targeted UI fixes to the landing pages: the careers job row hover now uses a
Confidence Score: 5/5All three changes are isolated UI fixes with no shared state, no API surface changes, and no data mutations — safe to merge. The TrustedBy removal is a clean one-liner with no leftover references. The inset hover pattern is well-established and the parent containers have no overflow clipping that could clip the negative margin bleed. The canSubmit gate covers exactly the five required fields, skips the optional company field correctly, and composes with the existing isBusy guard without introducing any new submission paths. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User fills Contact Form] --> B{canSubmit?}
B -- "name ✓\nemail valid ✓\ntopic ✓\nsubject ✓\nmessage ✓" --> C[Submit button enabled]
B -- "any field empty\nor email invalid" --> D[Submit button disabled]
C --> E{isBusy?}
E -- "isPending or isSubmitting" --> D
E -- "idle" --> F[handleSubmit fires]
F --> G[Zod contactRequestSchema.safeParse]
G -- invalid --> H[Show field errors, done]
G -- valid --> I[Run Turnstile captcha]
I --> J[contactMutation.mutate]
J -- success --> K[Show confirmation state]
J -- error --> L[Show submitError, reset captcha]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[User fills Contact Form] --> B{canSubmit?}
B -- "name ✓\nemail valid ✓\ntopic ✓\nsubject ✓\nmessage ✓" --> C[Submit button enabled]
B -- "any field empty\nor email invalid" --> D[Submit button disabled]
C --> E{isBusy?}
E -- "isPending or isSubmitting" --> D
E -- "idle" --> F[handleSubmit fires]
F --> G[Zod contactRequestSchema.safeParse]
G -- invalid --> H[Show field errors, done]
G -- valid --> I[Run Turnstile captcha]
I --> J[contactMutation.mutate]
J -- success --> K[Show confirmation state]
J -- error --> L[Show submitError, reset captcha]
Reviews (2): Last reviewed commit: "fix(landing): inset careers row hover, d..." | Re-trigger Greptile |
fe0761b to
131bcbd
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 131bcbd. Configure here.
Summary
Type of Change
Testing
Tested manually — verified hover spacing on careers job rows, confirmed the trusted-by section no longer renders on /careers, and confirmed the contact submit button is disabled on an empty form and enables once all required fields are valid.
Checklist