Skip to content

fix(landing): inset careers row hover, drop trusted-by section, gate contact submit#5380

Merged
waleedlatif1 merged 1 commit into
stagingfrom
worktree-careers-contact-fixes
Jul 2, 2026
Merged

fix(landing): inset careers row hover, drop trusted-by section, gate contact submit#5380
waleedlatif1 merged 1 commit into
stagingfrom
worktree-careers-contact-fixes

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Careers job row hover now insets text/highlight slightly from the row edges instead of running flush to the container
  • Removed the "Trusted by technical teams at" logo section from the careers page
  • Contact form submit button now stays disabled until all required fields (name, valid email, topic, subject, message) are filled, matching the demo form's pattern

Type of Change

  • Bug fix

Testing

Tested manually — verified hover spacing on careers job rows, confirmed the trusted-by section no longer renders on /careers, and confirmed the contact submit button is disabled on an empty form and enables once all required fields are valid.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 2, 2026 7:54pm

Request Review

@cursor

cursor Bot commented Jul 2, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Cosmetic careers layout changes and client-side submit gating only; server validation on contact submit is unchanged.

Overview
Landing polish on careers, job rows, and contact.

The careers page no longer renders the Trusted by logo block below open roles.

Each careers job link row gets inset horizontal padding (-mx-3 / px-3), rounded corners, and the same hover background so the highlight does not run flush to the list edges.

The contact form Send message button stays disabled until name, a valid email (quickValidateEmail), topic, subject, and message are all non-empty—aligned with the demo form—while still respecting the existing busy/submitting state.

Reviewed by Cursor Bugbot for commit 131bcbd. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Three targeted UI fixes to the landing pages: the careers job row hover now uses a -mx-3/px-3 inset pattern with rounded-lg so the highlight has breathing room from the row edges; the TrustedBy logo section is removed from /careers; and the contact form's submit button is disabled until all required fields pass client-side validation.

  • Job row hover (job-groups.tsx): adds -mx-3 rounded-lg and px-3 to the anchor so the hover highlight bleeds slightly into the section's px-12 padding while text stays in place — a standard "padded hover" pattern with no layout side-effects given none of the parent containers carry overflow-hidden.
  • TrustedBy removal (careers.tsx): single-line removal of the import and JSX usage; no orphaned references remain.
  • Contact canSubmit (contact-form.tsx): derives a boolean over the five required fields (name, email via quickValidateEmail, topic, subject, message) and ORs it into the existing isBusy guard on the submit Chip, mirroring the demo form's pattern exactly.

Confidence Score: 5/5

All three changes are isolated UI fixes with no shared state, no API surface changes, and no data mutations — safe to merge.

The TrustedBy removal is a clean one-liner with no leftover references. The inset hover pattern is well-established and the parent containers have no overflow clipping that could clip the negative margin bleed. The canSubmit gate covers exactly the five required fields, skips the optional company field correctly, and composes with the existing isBusy guard without introducing any new submission paths.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/(landing)/careers/careers.tsx Removes the TrustedBy import and its JSX usage cleanly; no orphaned imports or references remain.
apps/sim/app/(landing)/careers/components/job-board/job-groups.tsx Applies the standard negative-margin/padding inset hover pattern (-mx-3, px-3, rounded-lg) to JobRow; parent containers have no overflow-hidden so the bleed is safe.
apps/sim/app/(landing)/contact/components/contact-form/contact-form.tsx Adds canSubmit gate covering all five required fields; correctly skips optional company, mirrors demo-form pattern, and composes cleanly with the existing isBusy guard.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User fills Contact Form] --> B{canSubmit?}
    B -- "name ✓\nemail valid ✓\ntopic ✓\nsubject ✓\nmessage ✓" --> C[Submit button enabled]
    B -- "any field empty\nor email invalid" --> D[Submit button disabled]
    C --> E{isBusy?}
    E -- "isPending or isSubmitting" --> D
    E -- "idle" --> F[handleSubmit fires]
    F --> G[Zod contactRequestSchema.safeParse]
    G -- invalid --> H[Show field errors, done]
    G -- valid --> I[Run Turnstile captcha]
    I --> J[contactMutation.mutate]
    J -- success --> K[Show confirmation state]
    J -- error --> L[Show submitError, reset captcha]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[User fills Contact Form] --> B{canSubmit?}
    B -- "name ✓\nemail valid ✓\ntopic ✓\nsubject ✓\nmessage ✓" --> C[Submit button enabled]
    B -- "any field empty\nor email invalid" --> D[Submit button disabled]
    C --> E{isBusy?}
    E -- "isPending or isSubmitting" --> D
    E -- "idle" --> F[handleSubmit fires]
    F --> G[Zod contactRequestSchema.safeParse]
    G -- invalid --> H[Show field errors, done]
    G -- valid --> I[Run Turnstile captcha]
    I --> J[contactMutation.mutate]
    J -- success --> K[Show confirmation state]
    J -- error --> L[Show submitError, reset captcha]
Loading

Reviews (2): Last reviewed commit: "fix(landing): inset careers row hover, d..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 force-pushed the worktree-careers-contact-fixes branch from fe0761b to 131bcbd Compare July 2, 2026 19:54
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 131bcbd. Configure here.

@waleedlatif1 waleedlatif1 merged commit 577a7a2 into staging Jul 2, 2026
13 checks passed
@waleedlatif1 waleedlatif1 deleted the worktree-careers-contact-fixes branch July 2, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant