feat(run-ops): cross-producer ClickHouse version helper + cross-Postgres-version compat tests#4114
feat(run-ops): cross-producer ClickHouse version helper + cross-Postgres-version compat tests#4114d-cs wants to merge 3 commits into
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 563aa33c-379c-4ce9-8475-3f0a90c52618
📒 Files selected for processing (5)
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (9)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Usepnpm run typecheckfor changes in apps (apps/*) and internal packages (internal-packages/*), and never usebuildto verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamicimport(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.
Files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}
📄 CodeRabbit inference engine (CLAUDE.md)
Always import from
@trigger.dev/sdkwhen writing Trigger.dev tasks; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
internal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
**/*.{test,spec}.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Place test files next to the source files they cover (for example,
MyService.ts->MyService.test.ts).
Files:
internal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{test,spec}.{ts,tsx,js,jsx}: Write unit tests with Vitest, keep test files beside the files under test, and use descriptivedescribeanditblocks.
Avoid mocks or stubs in tests; when Redis or Postgres are needed, use the helpers from@internal/testcontainers.
Files:
internal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
internal-packages/run-engine/src/engine/tests/**/*.test.ts
📄 CodeRabbit inference engine (internal-packages/run-engine/CLAUDE.md)
Implement tests for RunEngine in
src/engine/tests/using testcontainers for Redis and PostgreSQL containerization
Files:
internal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
🧠 Learnings (11)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/clickhouse/src/index.tsinternal-packages/clickhouse/src/taskRuns.tsinternal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/clickhouse/src/taskRuns.test.tsinternal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.tsinternal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts
🔇 Additional comments (5)
internal-packages/clickhouse/src/index.ts (1)
81-81: LGTM!internal-packages/clickhouse/src/taskRuns.test.ts (1)
6-6: LGTM!Also applies to: 892-1199
internal-packages/clickhouse/src/taskRuns.ts (1)
221-229: 🗄️ Data Integrity & IntegrationNo change needed here.
composeTaskRunVersionintentionally keeps the low 56 bits oflsnVersionto preserve in-producer ordering.> Likely an incorrect or invalid review comment.internal-packages/run-engine/src/engine/tests/heteroPostgresFixture.test.ts (1)
4-40: LGTM!internal-packages/run-engine/src/engine/tests/crossVersionCompat.test.ts (1)
416-430: 🩺 Stability & AvailabilityVerify repeatability/cleanup for the env-gated dedicated-DB path.
The seed helpers insert fixed literal IDs (
org_xv_*,proj_xv_*, etc.) via plainINSERTwith noON CONFLICTonOrganization/Project/RuntimeEnvironment/TaskRun, and nothing tears down data on the persistent dedicated DB. Unlike the container clients (fresh per-test clones), a realCROSS_VERSION_DEDICATED_URLdatabase is durable, so a second run of this corpus will fail on duplicate primary keys. Please confirm the CI job provisions a clean DB per run (or add cleanup /ON CONFLICT DO NOTHINGto the seed inserts) before enabling this hook.
d-cs
force-pushed
the
runops/pr02-db-foundation
branch
from
32525bb to
9b2b67d
Compare
d-cs
force-pushed
the
runops/pr03-clickhouse-tc
branch
from
7e5633b to
d331802
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
…ers run-ops dep Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nation test The keyset walk paged with createdAt > cursor while ordering DESC, so it re-fetched newer rows instead of advancing to older ones and terminated after one page — never exercising the page boundary. Both clients failed identically, so the equality assertion passed on broken data. Use a composite (createdAt, id) cursor with the correct direction so paging walks the full corpus and applies the id tie-break across tie groups. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d-cs
force-pushed
the
runops/pr02-db-foundation
branch
from
d1fd926 to
dc3d806
Compare
d-cs
force-pushed
the
runops/pr03-clickhouse-tc
branch
from
5021523 to
857e7d6
Compare
1 participant
What
composeTaskRunVersionto@internal/clickhouse(exported from the package index). It packs a smalloriginGenerationepoch into the top 8 bits of the ReplacingMergeTree version and keeps the producer's own LSN in the low 56 bits, sotask_runs_v2rows replicated from more than one Postgres producer become globally comparable while preserving in-producer ordering. Single-producer setups never call it and keep using the raw LSN version.taskRuns.test.ts(bit layout, ordering, epoch precedence, range validation).heteroPostgresFixture.test.ts— a smoke test asserting byte-identity and identicalORDER BY(under a pinned ICU collation) across two different Postgres major versions.crossVersionCompat.test.ts— mirrors the run-engine's real raw-SQL surfaces and asserts byte-identical, ordering-identical results across the two versions. Ships with an env-gated block (skipped by default) that can be pointed at a real dedicated database in CI.Why
Third PR in the run-ops split stack. It is purely additive: it introduces one new exported helper plus tests and changes no runtime call sites, so on its own it has no runtime behavior change. It lays down the version-composition primitive and the cross-version compatibility proof that later PRs in the stack rely on.
Tests
composeTaskRunVersionininternal-packages/clickhouse/src/taskRuns.test.ts(run against a real ClickHouse testcontainer).internal-packages/run-engine/src/engine/tests/running against real Postgres containers of two different major versions (no mocks). The env-gated dedicated-database block is skipped unless its URL is set.Notes
Draft, stacked on #4113 (
runops/pr02-db-foundation). Review that first; this diff is against it.Server-change / changeset note to be added at stack-assembly time.
🤖 Generated with Claude Code